Template talk:GetBuffInfo

Changes to 1.4 Pet Buff names

Posted the proposed changes at User:Awesome diamonds/Sandbox/testpage

About categorizing buffs as "Debuffs"

Just noticed that the categorization of debuffs in this template do not strictly follow the Main.debuff field in the source code.

• The following buffs are categorized as buffs while being debuffs: 28 (Werewolf), 34 (Merfolk), 87 (Cozy Fire), 89 (Heart Lamp), 146 (Happy!), 147 (Banner), 157 (Peace Candle), 158 (Star in a Bottle), 215 (The Bast Defense)
• The following buffs are categorized as debuffs while not being included in the Main.debuff field: 72 (Midas), 169 (Penetrated), 203 (Betsy's Curse), 204 (Oiled), 334 (Blood Butchered), and all whip tags (307, 309, 310, 313, 315, 316, 319, 326, 340)

Should these buffs' type be changed for better consistency? BadPiggy1024 (talk) 03:58, 29 August 2025 (UTC)

Good catch. I'm afraid these changes would be quite counter-intuitive, though. The definition of debuffs includes: "Debuffs are almost universally negative or at least malign effects, in contrast with buffs, over which the player has much more control." Merfolk, for example, has no negative effects at all and you have full control over when it's active or not, so classifying it as a debuff would be questionable. I didn't check the code, but I'm guessing that in this case Main.debuff only indicates that you can't remove the buff with a right click?

That said, the discrepancy could still be worth documenting. Off the top of my head, {{getBuffInfo|...|type}} is used at least by the automatic mode of {{item infobox}} (but probably also other stuff), for the "Grants buff/debuff" heading and categorization, so it's probably better not to touch that one. What about adding a new field instead? Maybe internaltype or debuffinternally or something like that. The Buff IDs table might a be good candidate to showcase this data.

--Rye Greenwood (talk) 16:45, 8 September 2025 (UTC)